Skip to content
This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion WordPressAuthenticator.podspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = "WordPressAuthenticator"
s.version = "1.33.0-beta.1"
s.version = "1.33.0-beta.2"
s.summary = "WordPressAuthenticator implements an easy and elegant way to authenticate your WordPress Apps."

s.description = <<-DESC
Expand Down
4 changes: 0 additions & 4 deletions WordPressAuthenticator/NUX/NUXLinkAuthViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,4 @@ class NUXLinkAuthViewController: LoginViewController {
override func configureStatusLabel(_ message: String) {
statusLabel?.text = message
}

override func updateSafariCredentialsIfNeeded() {
// Noop
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -226,13 +226,6 @@ class LoginSelfHostedViewController: LoginViewController, NUXKeyboardResponder {
// MARK: - Instance Methods


/// Noop. Required by the SigninWPComSyncHandler protocol but the self-hosted
/// controller's implementation does not use safari saved credentials.
///
override func updateSafariCredentialsIfNeeded() {
}


/// Validates what is entered in the various form fields and, if valid,
/// proceeds with the submit action.
///
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -206,14 +206,6 @@ class LoginUsernamePasswordViewController: LoginViewController, NUXKeyboardRespo

// MARK: - Instance Methods


/// Noop. Required by the SigninWPComSyncHandler protocol but the self-hosted
/// controller's implementation does not use safari saved credentials.
///
override func updateSafariCredentialsIfNeeded() {
}


/// Validates what is entered in the various form fields and, if valid,
/// proceeds with the submit action.
///
Expand Down
8 changes: 0 additions & 8 deletions WordPressAuthenticator/Signin/LoginViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -220,12 +220,6 @@ open class LoginViewController: NUXViewController, LoginFacadeDelegate {

presentUnified2FA()
}

// Update safari stored credentials. Call after a successful sign in.
///
func updateSafariCredentialsIfNeeded() {
SafariCredentialsService.updateSafariCredentialsIfNeeded(with: loginFields)
}

private enum LocalizedText {
static let loginError = NSLocalizedString("Whoops, something went wrong and we couldn't log you in. Please try again!", comment: "An error message shown when a wpcom user provides the wrong password.")
Expand Down Expand Up @@ -261,8 +255,6 @@ extension LoginViewController {
/// Signals the Main App to synchronize the specified WordPress.com account.
///
private func syncWPCom(credentials: AuthenticatorCredentials, completion: (() -> ())? = nil) {
SafariCredentialsService.updateSafariCredentialsIfNeeded(with: loginFields)

configureStatusLabel(LocalizedText.gettingAccountInfo)

authenticationDelegate.sync(credentials: credentials) { [weak self] in
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -150,11 +150,6 @@ final class SiteCredentialsViewController: LoginViewController {
}
}

/// No-op. Required by the SigninWPComSyncHandler protocol but the self-hosted
/// controller's implementation does not use safari saved credentials.
///
override func updateSafariCredentialsIfNeeded() {}

/// No-op. Required by LoginFacade.
func displayLoginMessage(_ message: String) {}
}
Expand Down