-
Notifications
You must be signed in to change notification settings - Fork 11
Shorter sign up - remove Send Link by email screen #574
Conversation
|
@mattmiklic , do you think we should update the copy on the first screen to let them know it has to be on the device? |
|
I don't think we need to add any messaging to the Get Started screen, since at that point they could intend to log in via password and the email note wouldn't be relevant. The email confirmation is clear enough that it should be checked on the device, I think. I do think it'd be good to add a message to the email confirmation screen letting them know they can go back if they didn't intend to sign up. Something like "Didn't mean to create a new account? Go back to re-enter your email address." |
Love it! I'll add it. Thank you so much, @mattmiklic ! |
|
I assume this isn't done yet since the "Didn't mean to create a new account?" message hasn't been added. So I'll just leave a comment that the podspec version needs to be bumped. |
ctarda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a quick test with WooCommerce, and even though this breaks the API, it does not remove any functionality that we might be using at the moment.
That being said, I would wait to merge, if possible, until @Garance91540 gives the 👍
WordPressAuthenticator/Unified Auth/View Related/Get Started/GetStartedViewController.swift
Show resolved
Hide resolved
|
Added copy: |
|
Looking good to me. 👍 |
ScoutHarris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. After the version is corrected,
.
emilylaguna
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this on:
- iPhone Simulator - iOS 13
- iPhone Simulator - iOS 14
- iPad Simulator - iOS 14
- Real Device: iPhone 11 Pro
Had no issues other than the unrelated login issue
LGTM 🚀 !
86218ad to
77c6c9e
Compare
jkmassel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version change LGTM – I presume all the other files have no changed.
![]()

After talking this over with design (@mattmiklic ) we decided to remove this screen:

Instead, we will be sending the email immediately after the user entered their email :
RPReplay_Final1612412851.MP4
To test: