This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Stop tracking prologue step based on view presentation #578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilylaguna
approved these changes
Feb 24, 2021
Contributor
emilylaguna
left a comment
emilylaguna
left a comment
There was a problem hiding this comment.
This is working for me 🚀. Started logged in:
- Logged out
- Got:
🔵 Tracked: unified_login_step <flow: prologue, source: default, step: prologue> - Restarted the app
- Got
🔵 Tracked: unified_login_step <flow: prologue, source: default, step: prologue> - Went through the login flow did not see that log again
I also tested the GoogleSignupConfirmationViewController which uses isBeingPresentedInAnyWay and verified it is still working correctly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue introduced when WordPress for iOS switched to displaying the authenticator as the window's root view controller instead of modally. That change meant that the previous check for
isBeingPresentedInAnyWayalways returned false, so we didn't track the prologue step.This PR reverts to the previous method of tracking whether this is the first time the view controller has appeared, using a simple property.
Please test using the associated WPiOS PR: wordpress-mobile/WordPress-iOS#15967