This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Updating WPKit pod version. #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@mindgraffiti could I bother you for a quick review please? Thank you! |
Contributor
Author
|
Sorry @mindgraffiti . Please hold off on this. |
mindgraffiti
approved these changes
Apr 23, 2019
Contributor
mindgraffiti
left a comment
mindgraffiti
left a comment
There was a problem hiding this comment.
Can confirm, recent changes to WordPressKit-iOS are isolated changes and aren't used by Authenticator.
pod install with updated WPKit ✅
builds fine ✅
unit tests ✅
Thanks for keeping Authenticator's pods up-to-date @ScoutHarris!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates WordPressKit to the latest version.
To test:
Build and test. Verify tests pass.