This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Stats: fetching posting events #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScoutHarris
approved these changes
Feb 21, 2019
| extension StatsServiceRemoteV2 { | ||
|
|
||
| // PublishedPostsStatsType hit a different endpoint and with different parameters | ||
| // then the rest of the time-based types — we need tco handle them separately here. |
Contributor
There was a problem hiding this comment.
Minor type - tco = to.
| case .year: | ||
| let yearAgo = Calendar.autoupdatingCurrent.date(byAdding: .year, value: -1, to: endDate)! | ||
| let january = Calendar.autoupdatingCurrent.date(bySetting: .month, value: 1, of: yearAgo)! | ||
| let jan1 = Calendar.autoupdatingCurrent.date(bySetting: .day, value: 1, of: january)! |
Contributor
There was a problem hiding this comment.
Does jan1 mean "Jan is number 1!"? Subliminal messaging. I like it. 😉
Contributor
Author
There was a problem hiding this comment.
dang you caught me :D
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DJ Khaled voice: Another one!
This adds support for fetching posts published in a specified timeframe in the new architecture.
Testing Details
Verify the library builds
Verify the tests pass
Please check here if your pull request includes additional test coverage.