This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Atomic Authentication Service. #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
leandroalonso
left a comment
leandroalonso
left a comment
There was a problem hiding this comment.
Just a minor comment, @diegoreymendez
leandroalonso
approved these changes
Mar 10, 2020
This was referenced Mar 10, 2020
Integrate WPKit 4.6.0-beta.2 into the Authenticator.
wordpress-mobile/WordPressAuthenticator-iOS#198
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #216
Implements the Atomic Auth Service to retrieve a cookie for previewing sites, pages and posts in Atomic Private Sites.
Related PRs:
WPiOS integration branch:
try/integrate-wpkit-216-AtomicAuthenticationServiceRemoteTesting Details
This isn't used anywhere, so there's no manual testing step yet, but I added a unit test to verify the service works as expected.
Feel free to ask me for my PAW file for testing the endpoint manually and comparing with the unit test if you think that's necessary.