This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Add support for marking Reader posts seen/unseen #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
3 tasks
9 tasks
aerych
suggested changes
Jan 14, 2021
Contributor
aerych
left a comment
aerych
left a comment
There was a problem hiding this comment.
Hola @ScoutHarris 👋
I had just one nitpick looking at the code.
Back to you!
| ] as [String: AnyObject] | ||
|
|
||
| wordPressComRestApi.POST(path, parameters: params, success: { (responseObject, httpResponse) in | ||
| success() |
Contributor
There was a problem hiding this comment.
Probably we should check what's returned in the response object. It should be a dictionary with a single key status. The value of status can be true or false depending on if the call succeeded. Looks like there are a few (unlikely) scenarios where false could be returned.
Contributor
Author
There was a problem hiding this comment.
Good catch. And done!
Contributor
Author
|
Thanks @aerych ! |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ref wordpress-mobile/WordPress-iOS#15355
WPiOS PR: wordpress-mobile/WordPress-iOS#15638
This adds functionality to toggle a post's
is_seenstatus.Testing Details
Can be tested with the referenced WPiOS PR.