Stats: fetching clicks / referrer #97
Conversation
|
|
||
| self.title = title | ||
| self.clicksCount = clicksCount | ||
| self.clickedURL = urlString.flatMap { URL(string: $0) } |
There was a problem hiding this comment.
I recognize why we'd use flatMap on a collection. It appears that the benefit in this case is to handle the optionality of icon & urlString, correct?
There was a problem hiding this comment.
Exactly! It saves us doing something like:
let clickedURL: URL?
if let urlString = urlString {
clickedURL = URL(string: urlString)
} else {
clickedURL = nil
}Just a bit of syntactic sugar.
| public let period: StatsPeriodUnit | ||
| public let periodEndDate: Date | ||
|
|
||
| public let totalReferrerViews: Int |
There was a problem hiding this comment.
In ClicksStatsType, there appears to be an analogous property called totalClicksCount. Is this worth renaming to totalViewsCount or totalRefererredViewsCount for consistency with that and StatsReferrer (viewsCount) below?
There was a problem hiding this comment.
Yup, absolutely! Thanks for catching that!
| public let periodEndDate: Date | ||
|
|
||
| public let totalReferrerViews: Int | ||
| public let otherReferrerViews: Int |
There was a problem hiding this comment.
If we embrace the suggestion above, it is also applicable here.
|
@jklausa I just noted that the hash in |
Description
Adds support for fetching clicks and referrer data.
They're so similar in shape I took the liberty of grouping them both in one PR
Testing Details