Skip to content
This repository was archived by the owner on Dec 11, 2017. It is now read-only.
This repository was archived by the owner on Dec 11, 2017. It is now read-only.

Revisit CodeMirror filters #35

@westonruter

Description

@westonruter

There are currently filters for theme_editor_codemirror_opts, plugin_editor_codemirror_opts, and customizer_custom_css_codemirror_opts. By returning a falsey value from any of these filters, it will cause CodeMirror to not be displayed on the related screen. There is no such filter for the Custom HTML widget. Moreover, the short-circuit via these filters is not the same as short-circuiting via the user profile screen. The two should be unified so that the no CodeMirror assets are enqueued if it will be disabled anyway. Do we need a separate filter for each context? Or should one filter be used for each, but an additional context param provided to distinguish where the editor is going to be rendered?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions