Skip to content

Conversation

@mlima95
Copy link
Contributor

@mlima95 mlima95 commented Oct 25, 2022

I added bindings feature for the area objects

@mlima95 mlima95 requested a review from moufmouf October 25, 2022 15:55
@codecov-commenter
Copy link

Codecov Report

Base: 55.17% // Head: 55.17% // No change to project coverage 👍

Coverage data is based on head (6aa29e0) compared to base (1ff439b).
Patch has no changes to coverable lines.

❗ Current head 6aa29e0 differs from pull request most recent head 1edcbbb. Consider uploading reports for the commit 1edcbbb to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #190   +/-   ##
=======================================
  Coverage   55.17%   55.17%           
=======================================
  Files           1        1           
  Lines          29       29           
  Branches        5        5           
=======================================
  Hits           16       16           
  Misses         13       13           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mlima95 mlima95 self-assigned this Oct 25, 2022
Comment on lines 55 to 56
If you want to use bindings with area object you have to set a custom property "Dynamic" to true
but if you set the Dynamic property, you can't use the map editor for this area.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you want to use bindings with area object you have to set a custom property "Dynamic" to true
but if you set the Dynamic property, you can't use the map editor for this area.
To use bindings with area objects, you must first set a custom "dynamic" property to true.
It should be noted that "dynamic" areas are accessible via the scripting API but are not editable in the (upcoming) map editor.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to the "context" section

@moufmouf moufmouf merged commit fc22865 into main Oct 26, 2022
github-actions bot pushed a commit that referenced this pull request Oct 26, 2022
## [1.4.5](v1.4.4...v1.4.5) (2022-10-26)

### Bug Fixes

* Properties templates area ([#190](#190)) ([fc22865](fc22865))
@github-actions
Copy link

🎉 This PR is included in version 1.4.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@moufmouf moufmouf deleted the propertiesTemplatesArea branch October 26, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants