Onboarding tutorial on first connection#84
Merged
moufmouf merged 34 commits intoJan 7, 2022
Conversation
moufmouf
reviewed
Dec 8, 2021
Collaborator
moufmouf
left a comment
moufmouf
left a comment
There was a problem hiding this comment.
We need a way to say the tutorial should be enabled (or disabled) by default.
So we need to add a property at the top level of the map.
Something like
tutorial: true
saying the tutorial should happen for this map.
Also, we need to add a documentation for the tutorial (in the /docs directory)
HimeShaman
force-pushed
the
first-connection-tutorial
branch
from
24c7cf6 to
17a392c
Compare
HimeShaman
force-pushed
the
first-connection-tutorial
branch
3 times, most recently
from
5e649a6 to
30d45ae
Compare
moufmouf
reviewed
Jan 4, 2022
added 24 commits
January 7, 2022 15:10
… fully hidden to the user
Co-authored-by: David Négrier <d.negrier@thecodingmachine.com>
HimeShaman
force-pushed
the
first-connection-tutorial
branch
from
90466c9 to
7d99885
Compare
Codecov Report
@@ Coverage Diff @@
## main #84 +/- ##
=======================================
Coverage 55.17% 55.17%
=======================================
Files 1 1
Lines 29 29
Branches 5 5
=======================================
Hits 16 16
Misses 13 13 Continue to review full report at Codecov.
|
moufmouf
added a commit
that referenced
this pull request
Jan 7, 2022
Onboarding tutorial on first connection (#84) * First commit - adds whole feature * Removes ts-ignore annotations * Uses player state in order to get and set "tutorialDone" value * Prettier refactoring * Makes tutorial iframe open under the player * WIP no overflows on sides * No more overflowing * Refactoring and test map update * Makes dialog box slightly transparent so the player position is never fully hidden to the user * Typo fix * Deletes redo button + slight refactoring * WIP tutorial iteration * EndWIP: makes tutorial follow player and switches Walter for Tutopi * Adjusts html/css for mobile version * Uses the camera API to prevent the iframe from crossing worldView boundaries * horizontal borders based on available area * Mobile integration * Responsive style for both mobile and desktop * Adds new assets and make the iFrame fit whatever the scaling is * Adds new video assets and clean old ones + config adjusted * Uses the player state to trigger tutorial * Removes unused css * Test map updates: shortcut to corners * fix wrong original y value for the iframe * Completes the test map * Factorise regex for user agent * Removes unused console.log * Makes the tutorial optional depending on associated map prop * Adds documentation * Typo correction * Update docs/reference.md Co-authored-by: David Négrier <d.negrier@thecodingmachine.com> * imports WasCameraUpdatedEvent from typings package * Updates packages * Corrects types Co-authored-by: Benedicte Quimbert <b.quimbert@workadventu.re> Co-authored-by: David Négrier <d.negrier@thecodingmachine.com>
github-actions Bot
pushed a commit
that referenced
this pull request
Jan 7, 2022
# [1.2.0](v1.1.1...v1.2.0) (2022-01-07) ### Features * **tutorial:** adding an easy to add "tutorial" ([ff749c8](ff749c8)), closes [#84](#84)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will need code from this PR on workadventure to work