GTK Critical on selection of popover menu in Preview panel

[ericlesslie]

Description

GTK Critical warning when opening the popover menu in the Preview panel. It doesn't seem to cause any problems, but is unpleasant to see in the Console. This doesn't happen in the other headerbar menus.

Debugging Information

re.sonny.Workbench 44.2
org.gnome.Platform 44

GJS 1.76.2
Adw 1.3.3
GTK 4.10.4
GLib 2.76.3
Flatpak 1.15.4
Vala 0.56.9
Blueprint 0.8.1

Potential Causes

I believe it's something to do with the different declarations for the headerbars of the panels in the window.blp for the headerbar menus , since the UI and Code panels have no warnings.

[ericlesslie]

Duplicate of #179

[sonnyp]

This is not a duplicate of #179

Thank you for the bug report. Would you like to give it a go? Looks like it might be worth trying the different declaration you found.

You can use GNOME Builder to clone and builder Workbench

[ericlesslie]

I just attempted to recreate on the current main branch and I couldn't reproduce the error. I'm unsure if it's worth going through the commits to find what fixed the warnings.

Figure 1: Screenshot after opening and closing menus

But I think that the issue could remain up as an enhancement, since consolidating these popover menus to one style seems like a good small enchancement to the app.

UI Panel	Preview Panel

Figure 2: Tables of UI differences

[TitouanReal]

This issue seems related to this GTK issue. I believe it is fixed in GTK 4.10.5 and 4.12.