Destroy toplevel objects #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonnyp
commented
Nov 26, 2022
Comment on lines
80
to
84
| // FIXME: working for Internal but not here | ||
| // the list of root objects keeps growing in Inspector as you make changes to UI | ||
| // Toplevel windows returned by these functions will stay around until the user explicitly destroys them with gtk_window_destroy(). | ||
| // https://docs.gtk.org/gtk4/class.Builder.html | ||
| target.destroy(); |
Contributor
Author
There was a problem hiding this comment.
@lw64 could you look into why this doesn't work on the external previewer and global objects keep accumulating when making changes ?
How to reproduce:
- Select the
Application windowexample - Selecting Vala
- Entering the following code:
#!/usr/bin/env -S vala workbench.vala --pkg gtk4 --pkg libadwaita-1
public void main() {}- Hit
Run - Open the GTK Inspector on the preview window/process
- Make changes to
UI - Observe the list of global objects grow for each change
sonnyp
commented
Nov 26, 2022
sonnyp
force-pushed
the
destroy-toplevel-objects
branch
from
7f1a687 to
4df25b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.