Library: add Drag-and-Drop entry #253
Conversation
sonnyp
force-pushed
the
main
branch
3 times, most recently
from
05f69f1 to
55e450f
Compare
|
Any chance you could pick this up again? It would be great to have this. |
|
I'll take another crack at it |
|
accident, this is not ready for review |
Co-authored-by: Andy Holmes <1265208+andyholmes@users.noreply.github.com>
Co-authored-by: Andy Holmes <1265208+andyholmes@users.noreply.github.com>
Co-authored-by: Andy Holmes <1265208+andyholmes@users.noreply.github.com>
|
I'm still struggling to get the drop working. It seems like the "drop" signal never fires. I am learning a lot more though, I'm gonna redo drag-and-drop in my own app. |
sonnyp
left a comment
sonnyp
left a comment
There was a problem hiding this comment.
Design review:
- The drag icon should be dimmed
- There should be visual feedback of where the row is going to be dropped (swapped with)
- There should be a hover effect on each row
You can look at GNOME Settings -> Search for all 3
I suggest you implement these things and then @andyholmes can do the technical review.
|
@halfmexican please request review from @andyholmes if this is ready
|
andyholmes
left a comment
andyholmes
left a comment
There was a problem hiding this comment.
Looks really good, a nice clean example of implementing drag-and-drop. Just a few cleanups and it LGTM.
|
I think we're ready to merge |
andyholmes
left a comment
andyholmes
left a comment
There was a problem hiding this comment.
Looks perfect to me, thanks for sticking with this one, it will be a very helpful demo.
Add a basic example of Drag-and-Drop, with re-orderable list box rows.
Add a basic example of Drag-and-Drop, with re-orderable list box rows.
3 participants
Currently just drafting this as i'm having difficultly porting my drag and drop to javascript from vala and school work is eating my schedule