Skip to content

Conversation

@halfmexican
Copy link
Contributor

@halfmexican halfmexican commented May 30, 2023

I'm still not sure why I am getting this error.
image

closes #288

@halfmexican halfmexican linked an issue May 30, 2023 that may be closed by this pull request
Copy link
Contributor

@sonnyp sonnyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@sonnyp
Copy link
Contributor

sonnyp commented May 30, 2023

BTW I don't get these errors. Can you see if you can reproduce after flatpak update and restarting Workbench?

@halfmexican
Copy link
Contributor Author

I still get the errors even after flatpak update

@halfmexican halfmexican requested a review from sonnyp May 31, 2023 17:59
Copy link
Contributor

@sonnyp sonnyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I fixed a couple of minor issues d0ada53

@sonnyp
Copy link
Contributor

sonnyp commented Jun 3, 2023

@andyholmes do you want to have an other look?

@andyholmes
Copy link
Contributor

@andyholmes do you want to have an other look?

Looks good to me! Nice and clean, with lots of examples.

@sonnyp sonnyp merged commit ca34702 into main Jun 3, 2023
@sonnyp sonnyp deleted the halfmexican/adwpreferenceswindow branch June 3, 2023 18:27
sonnyp pushed a commit to krlade/Workbench that referenced this pull request Jun 3, 2023
sonnyp pushed a commit to SoNiC-HeRE/Workbench that referenced this pull request Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AdwPreferencesWindow

4 participants