-
-
Notifications
You must be signed in to change notification settings - Fork 90
library: add Overlay Split View entry #463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sonnyp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The window is too small and the sidebar should automatically show/hide depending on the window width.
Could you replicate exactly the "Adwaita Demo" example ?
I think it's what users want in 99% of cases.
|
overlay.webm |
sonnyp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were conflicts and unwanted changes in the diff.
I fixed it and merged main into your branch, please git pull.
So I don't know what's going on but here I get the following now:
Screencast.from.2023-08-09.21-09-20.webm
Are you using the same method as "Adwaita Demo" to set the window size?
|
Is this ready for review? |
|
Yes, I thought I forgot the tooltip text but it appears I did included that |
sonnyp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
I removed modal: true because without set_transient_for it feels buggy.
(Can't interact with Workbench window but there is no feedback as to why)
Fixes #406