Skip to content

Conversation

@halfmexican
Copy link
Contributor

@halfmexican halfmexican commented Aug 1, 2023

Fixes #406

@halfmexican halfmexican linked an issue Aug 1, 2023 that may be closed by this pull request
@halfmexican halfmexican changed the base branch from main to 45 August 3, 2023 16:00
@halfmexican halfmexican marked this pull request as ready for review August 3, 2023 16:01
@sonnyp sonnyp self-assigned this Aug 7, 2023
Copy link
Contributor

@sonnyp sonnyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The window is too small and the sidebar should automatically show/hide depending on the window width.

Could you replicate exactly the "Adwaita Demo" example ?

I think it's what users want in 99% of cases.

@sonnyp sonnyp changed the base branch from 45 to main August 7, 2023 15:25
@halfmexican
Copy link
Contributor Author

overlay.webm
The automatic hiding of the sidebar appears to work for me.

@halfmexican halfmexican requested a review from sonnyp August 9, 2023 17:33
Copy link
Contributor

@sonnyp sonnyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were conflicts and unwanted changes in the diff.

I fixed it and merged main into your branch, please git pull.

So I don't know what's going on but here I get the following now:

Screencast.from.2023-08-09.21-09-20.webm

Are you using the same method as "Adwaita Demo" to set the window size?

@sonnyp
Copy link
Contributor

sonnyp commented Aug 10, 2023

Is this ready for review?

@halfmexican halfmexican requested a review from sonnyp August 10, 2023 17:52
@halfmexican
Copy link
Contributor Author

Yes, I thought I forgot the tooltip text but it appears I did included that

Copy link
Contributor

@sonnyp sonnyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

I removed modal: true because without set_transient_for it feels buggy.

(Can't interact with Workbench window but there is no feedback as to why)

@sonnyp sonnyp merged commit 520c09a into main Aug 11, 2023
@sonnyp sonnyp deleted the halfmexican/overlay-split-view branch August 11, 2023 13:14
sonnyp pushed a commit to SoNiC-HeRE/Workbench that referenced this pull request Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add OverlaySplitView entry

3 participants