library: Remove usage of Adw.PreferencesWindow #949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial implementation to move away from Adw.PreferencesWindow for library Search non-functional as of now (Needs a different PR)
sonnyp
reviewed
Jun 24, 2024
Contributor
sonnyp
left a comment
sonnyp
left a comment
There was a problem hiding this comment.
Great start - I think in this PR we can focus on getting rid of PreferencesWindow only
Could you
- Remove the search icon
- Make sure the paddin at the bottom (when you scroll down) is as it was?
Then we can merge this. The next step would be to re-implement the search (not code) - for this I think a search input field always visible below "Learn, Test, Remix" would be best.
Reimplementing search would be a different PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation to move away from Adw.PreferencesWindow for library
To Do:
Adw.PreferencesWindowto alternative- [ ] Make search work (Shifting toAdw.Windowbreaks search )- [ ] Library design needs change + Categories and Language filtersLet me know if there are any changes to the latest commit
Screengrabs of the current state:
2024-06-24.20-57-30.mp4