library: Remove Usage of PreferencesPage and Group #958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial implementation -Design is still WIP Current bugs : -Labels for categories are added as a ListBox Row, design needs changes -Increasing window size increases the size of rows (ideal -> row length remains constant and only reduces in length when window is minimized)
sonnyp
reviewed
Jul 4, 2024
Contributor
sonnyp
left a comment
sonnyp
left a comment
There was a problem hiding this comment.
Please replica the previous design for now
Should be something like this
Box {
Label: {
label: "User Interface";
styles ["title-4"]
}
ListBox library_user_interface {
...
}
}
```
Contributor
|
Also, categories should be hidden on search |
Hide categories on search Remove separate boxes for each listbox + label combination Margins use hardcoded values to look similar to current Workbench
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation to remove usage of
Adw.PreferencesPageandAdw.PreferencesGroupCurrent bugs :
Labels for categories are added as a ListBox Row, design needs changesIncreasing window size increases the size of rows (ideal -> row length remains constant and only reduces in length when window is minimized)New issue after latest commit when searching for a demo, the size of the rows is set by looking at the row with maximum lengthScreengrab after commit 3
2024-07-05.19-36-10.mp4
After commit 4
2024-07-05.23-06-11.mp4