[Feature]: add NSISTP product and workflows to example orchestrator #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to downgrade NetBox version which I guess is not desirable? |
7 tasks
hanstrompert
force-pushed
the
41-feat/add-nsistp-products-and-workflows-with-yaml
branch
from
3b9f7e5 to
e63cf08
Compare
I rebased against master, NetBox is now at 4.4.1, which was the original/latest version, right? |
Removed forms volume from orchestrator service.
Updated the Netbox base image to version 4.4.1.
hanstrompert
force-pushed
the
41-feat/add-nsistp-products-and-workflows-with-yaml
branch
from
e63cf08 to
1367bfe
Compare
This reverts commit 0a9c1cc. At least PortsValueError is needed ...
Mark90
approved these changes
Oct 15, 2025
migrations/versions/schema/2025-08-28_0e8d17ce0f06_reconcile_workflows_l2vpn.py
Show resolved
Hide resolved
hanstrompert
approved these changes
Oct 20, 2025
| return TerminateNsistpForm | ||
|
|
||
|
|
||
| @step("Delete subscription from OSS/BSS") |
There was a problem hiding this comment.
This should be replaced by a @step("Remove VLANs from IMS") that actually removes the VLAN's from NetBox, as is done in terminate_l2vpn.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements NSISTP products, product blocks and workflows to add NSI support to the example orchestrator.
Included
Blocked by VlanRange issue: #54
Issue: #41