Skip to content

Conversation

@tjeerddie
Copy link
Contributor

@tjeerddie tjeerddie commented Apr 1, 2025

  • revalidate_fn: Callable function that returns bool whether to revalidate the cached result.
  • update unit tests.

@tjeerddie tjeerddie force-pushed the update-cached-result branch 3 times, most recently from 5490180 to 29c635e Compare April 1, 2025 13:05
@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.63%. Comparing base (2a8a97e) to head (a4648f3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   80.51%   80.63%   +0.12%     
==========================================
  Files          13       13              
  Lines         467      470       +3     
  Branches       62       63       +1     
==========================================
+ Hits          376      379       +3     
  Misses         71       71              
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tjeerddie tjeerddie force-pushed the update-cached-result branch from 29c635e to 36210c8 Compare April 1, 2025 13:11
@tjeerddie tjeerddie force-pushed the update-cached-result branch from 36210c8 to 4daeda6 Compare April 1, 2025 13:31
@tjeerddie tjeerddie changed the title Add revalidate_fn optional param to cached_result for additional check if cache should be used Add revalidate_fn optional param to cached_result for additional check if cache should be revalidated Apr 1, 2025
Copy link
Contributor

@Mark90 Mark90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small nit in testcode

- revalidate_fn: Callable function that returns bool whether to revalidate the cached result.
- update unit tests.
@tjeerddie tjeerddie force-pushed the update-cached-result branch from 4daeda6 to 748d3e7 Compare April 1, 2025 13:44
@Mark90 Mark90 merged commit 3036a32 into main Apr 1, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants