Skip to content

Conversation

@Mark90
Copy link
Contributor

@Mark90 Mark90 commented Apr 14, 2025

  • Omit 'self' argument from cache key generation -> This prevents memory addresses in generated keys when decorator is used on class methods
  • Raise warnings for potentially unsafe cache key arguments
  • Raise error when used on anything else than a coroutine
  • Raise error when no arguments are available for cache key generation

Relates to #45

@Mark90 Mark90 force-pushed the cached-result-improvements branch from a5ff57a to b394b17 Compare April 14, 2025 07:25
- Omit 'self' argument from cache key generation
- Raise warnings for potentially unsafe cache key arguments
- Raise error when used on anything else than a coroutine
- Raise error when no arguments are available for cache key generation
@Mark90 Mark90 force-pushed the cached-result-improvements branch from b394b17 to 5997c67 Compare April 14, 2025 07:31
@codecov
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

Attention: Patch coverage is 94.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.64%. Comparing base (3036a32) to head (82108a2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
nwastdlib/asyncio_cache.py 93.87% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   80.63%   81.64%   +1.00%     
==========================================
  Files          13       13              
  Lines         470      512      +42     
  Branches       63       70       +7     
==========================================
+ Hits          379      418      +39     
- Misses         71       73       +2     
- Partials       20       21       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Mark90 Mark90 merged commit fc02479 into main Apr 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants