Allow cached_result on function without args/kwargs, use func.__qualname__ in key #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version 1.10.0
cached_resultwas changed to not allow using it on a function without args/kwargs.This was an oversight: it works perfectly fine thanks to the function name itself being prefixed in the cache key.
Re-instated that behavior, now using
func.__qualname__instead offunc.__name__to have more context in the key.Example
Before this PR
Client.get_foo: raisesValueError: Cannot generate cache key without args/kwargs")Client.get_bar: generates cache keys{prefix}:{version}:get_bar:((1, ), frozenset())After this PR
Client.get_foo: generates cache keys{prefix}:{version}:client.get_fooClient.get_bar: generated cache keys{prefix}:{version}:client.get_bar:((1, ), frozenset())