feat: add group, pipes, and authorization additive API support#367
feat: add group, pipes, and authorization additive API support#367gjtorikian merged 2 commits intomainfrom
Conversation
Greptile SummaryThis auto-generated PR adds resource classes for Group events,
Confidence Score: 4/5The group and authorization classes look correct, but the Pipes access token fix is incomplete — the parent response class is still empty and the new nested types are never wired in. One P1 finding: the primary motivation of the PR (fixing missing data in the access token response) does not appear to be addressed in DataIntegrationAccessTokenResponse itself, which remains a no-op class. lib/Resource/DataIntegrationAccessTokenResponse.php (not in the diff but should be) and lib/Resource/DataIntegrationAccessTokenResponseAccessToken.php Important Files Changed
Class Diagram%%{init: {'theme': 'neutral'}}%%
classDiagram
class DataIntegrationAccessTokenResponse {
+fromArray(array data) self
+toArray() array
}
class DataIntegrationAccessTokenResponseAccessToken {
+string object
+string accessToken
+string|null expiresAt
+array scopes
+array missingScopes
}
class DataIntegrationAccessTokenResponseError {
<<enumeration>>
NeedsReauthorization
NotInstalled
}
DataIntegrationAccessTokenResponse ..> DataIntegrationAccessTokenResponseAccessToken : missing link
DataIntegrationAccessTokenResponse ..> DataIntegrationAccessTokenResponseError : missing link
class Group {
+string object
+string id
+string organizationId
+string name
+string|null description
+DateTimeImmutable createdAt
+DateTimeImmutable updatedAt
}
class GroupCreated { +Group data }
class GroupDeleted { +Group data }
class GroupUpdated { +Group data }
class GroupMemberAdded { +GroupMemberAddedData data }
class GroupMemberRemoved { +GroupMemberRemovedData data }
class GroupMemberAddedData {
+string groupId
+string organizationMembershipId
}
class GroupMemberRemovedData {
+string groupId
+string organizationMembershipId
}
GroupCreated --> Group
GroupDeleted --> Group
GroupUpdated --> Group
GroupMemberAdded --> GroupMemberAddedData
GroupMemberRemoved --> GroupMemberRemovedData
Reviews (2): Last reviewed commit: "fix core array issue" | Re-trigger Greptile |
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| // This file is auto-generated by oagen. Do not edit. | ||
|
|
||
| namespace WorkOS\Resource; | ||
|
|
||
| /** The [access token](https://workos.com/docs/reference/pipes/access-token) object, present when `active` is `true`. */ | ||
| readonly class DataIntegrationAccessTokenResponseAccessToken implements \JsonSerializable |
There was a problem hiding this comment.
New nested types never wired into parent class
DataIntegrationAccessTokenResponse (the class actually returned by Pipes::createDataIntegrationToken) is still completely empty — it has no constructor properties and deserializes nothing. The two new classes added in this PR (DataIntegrationAccessTokenResponseAccessToken, DataIntegrationAccessTokenResponseError) exist in isolation but are never referenced from DataIntegrationAccessTokenResponse, so callers still cannot access the access token, active flag, or error from the API response. The original "data was missing" bug is not fixed.
A user wrote in noting that some data was missing; this was due to a slight error in the oagen-emitter logic.