Skip to content

Support for GET /events endpoint #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
henrylamchan merged 5 commits into from
Jul 22, 2020
Merged

Support for GET /events endpoint #33

henrylamchan merged 5 commits into from
Jul 22, 2020

Conversation

@henrylamchan
Copy link
Contributor

@henrylamchan henrylamchan commented Jul 22, 2020 •
edited
Loading

  • Refactor capture_and_mock_requests
  • Add Resource base class
  • Add WorkOSEvent and WorkOSEventAction Resources
  • Add support for GET /events endpoint

@codecov
Copy link

codecov bot commented Jul 22, 2020 •
edited
Loading

Codecov Report

Merging #33 into master will decrease coverage by 3.60%.
The diff coverage is 86.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
- Coverage   97.14%   93.53%   -3.61%     
==========================================
  Files           9       12       +3     
  Lines         175      232      +57     
==========================================
+ Hits          170      217      +47     
- Misses          5       15      +10
Impacted Files Coverage Δ
workos/audit_trail.py 82.14% <75.60%> (-17.86%) ⬇️
workos/__about__.py 100.00% <100.00%> (ø)
workos/resources/base.py 100.00% <100.00%> (ø)
workos/resources/event.py 100.00% <100.00%> (ø)
workos/resources/event_action.py 100.00% <100.00%> (ø)
workos/resources/sso.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7594b03...38c575f. Read the comment docs.

@henrylamchan henrylamchan force-pushed the feature/ch2638/python-sdk-add-support-for-get-events-endpoint branch from c79dc40 to a1a1d01 Compare July 22, 2020 01:58
@henrylamchan henrylamchan marked this pull request as ready for review July 22, 2020 02:02
@marktran marktran requested a review from CelestineKao July 22, 2020 02:48
@henrylamchan henrylamchan force-pushed the feature/ch2638/python-sdk-add-support-for-get-events-endpoint branch from c9b8b22 to 81704d4 Compare July 22, 2020 15:15
@henrylamchan henrylamchan force-pushed the feature/ch2638/python-sdk-add-support-for-get-events-endpoint branch from 81704d4 to 38c575f Compare July 22, 2020 15:18
CelestineKao
CelestineKao reviewed Jul 22, 2020
View reviewed changes
CelestineKao
CelestineKao reviewed Jul 22, 2020
View reviewed changes
@henrylamchan henrylamchan merged commit eeb499f into master Jul 22, 2020
@henrylamchan henrylamchan deleted the feature/ch2638/python-sdk-add-support-for-get-events-endpoint branch July 22, 2020 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rohanjadvani rohanjadvani Awaiting requested review from rohanjadvani

1 more reviewer

@CelestineKao CelestineKao CelestineKao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@henrylamchan @CelestineKao