Skip to content

Conversation

@henrylamchan
Copy link
Contributor

Don't actually need to wrap the input in list()... it would actually break things in this case as it turns out something like list('abc') results in ['a', 'b', 'c'].

For requests, we can actually pass in the input as is because a string and a single element array are represented the same way by python requests. 'foo' and ['foo'] would be transformed into /events?group=foo.

@henrylamchan henrylamchan marked this pull request as ready for review July 23, 2020 01:09
@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #34 into master will not change coverage.
The diff coverage is 12.50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #34   +/-   ##
=======================================
  Coverage   93.53%   93.53%           
=======================================
  Files          12       12           
  Lines         232      232           
=======================================
  Hits          217      217           
  Misses         15       15           
Impacted Files Coverage Δ
workos/audit_trail.py 82.14% <0.00%> (ø)
workos/__about__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeb499f...00c55f2. Read the comment docs.

@henrylamchan henrylamchan merged commit 6cc2faa into master Jul 23, 2020
@henrylamchan henrylamchan deleted the fix_get_events_array_filtering branch July 23, 2020 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants