Add generate_link function to Portal module #39
Conversation
willmanduffy
commented
Sep 14, 2020
willmanduffy
commented
- Adds an SDK method to generate an Admin Portal link.
willmanduffy
requested review from
henrylamchan,
maxchehab and
rohanjadvani
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
==========================================
+ Coverage 94.07% 94.16% +0.09%
==========================================
Files 13 13
Lines 253 257 +4
==========================================
+ Hits 238 242 +4
Misses 15 15
Continue to review full report at Codecov.
|
willmanduffy
force-pushed
the
feature/ch3035/add-create-organization-method-to-python
branch
from
b16ddef to
0f006b4
Compare
| Args: | ||
| intent (str): The access scope for the generated Admin Portal link. Valid values are: ["sso"] | ||
| organization (string): The ID of the organization the Admin Portal link will be generated for | ||
| return_url (str): The URL that the end user will be redirected to upon exiting the generated Admin Portal. If none is provided, the default redirect link set in your WorkOS Dashboard will be used. (Optional) |
There was a problem hiding this comment.
Could you move return_url into a Kwargs section?
There was a problem hiding this comment.
Probably a discussion for some other time but... it's called return_url but we're using the default reDirect_uri if one is not supplied?
There was a problem hiding this comment.
Had the same question as I was writing this. @maxchehab?
There was a problem hiding this comment.
We are deciding to keep this as is. See slack convo.
workos/portal.py
Outdated
| "return_url": return_url, | ||
| } | ||
| return self.request_helper.request( | ||
| "portal/generate_link", |
There was a problem hiding this comment.
Could you create a constant for this for consistency?
| self._request_helper = RequestHelper() | ||
| return self._request_helper | ||
|
|
||
| def create_organization(self, organization): |
There was a problem hiding this comment.
Curious if Organizations are going to be used for anything else in the future. If so, would it make sense to put it into a Portal module or should it go somewhere else?
There was a problem hiding this comment.
We had this discussion as we kicked things off and it was decided that while it's not the best future home it is the one most consistent with the approach we've taken so far. In the future we might re-organize things to a more resource based approach, but that would have enough breaking changes we'd want it to be a major version.
willmanduffy
force-pushed
the
feature/ch3035/add-create-organization-method-to-python
branch
from
0f006b4 to
d033e28
Compare
* Adds an SDK method to generate an Admin Portal link.
willmanduffy
force-pushed
the
feature/ch3039/add-generate-portal-link-method-to-python
branch
from
a046a92 to
8d52d0d
Compare
|
@henrylamchan I've updated with all the outstanding changes. Ready for a another review! |
willmanduffy
deleted the
feature/ch3039/add-generate-portal-link-method-to-python
branch
3 participants
