Skip to content

feat(workos-python): Implement __str__ for BaseRequestException #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2021
Merged

feat(workos-python): Implement __str__ for BaseRequestException #57

merged 1 commit into from
Feb 23, 2021

Conversation

@rohanjadvani
Copy link
Contributor

Implement __str__ for a human-readable format as exceptions come up.

@rohanjadvani rohanjadvani requested a review from a team as a code owner February 23, 2021 17:38
@linear
Copy link

linear bot commented Feb 23, 2021

SDK-52 Raise exception with error message for errors on /sso/token

  • Implement toString
  • Show request id

Make this better:

  File "/app/app/oauth/routes.py", line 98, in oauth_callback
    profile = workos_client.sso.get_profile(code)
  File "/usr/local/lib/python3.7/site-packages/workos/sso.py", line 122, in get_profile
    TOKEN_PATH, method=REQUEST_METHOD_POST, params=params
  File "/usr/local/lib/python3.7/site-packages/workos/utils/request.py", line 74, in request
    raise BadRequestException(response)
workos.exceptions.BadRequestException: <Response [400]>

jthodge
jthodge approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@jthodge jthodge left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This'll be a much better improvement to the stack trace we currently surface :chef-kiss:

@rohanjadvani rohanjadvani merged commit 2cecd7b into master Feb 23, 2021
@rohanjadvani rohanjadvani deleted the feature/sdk-52-raise-exception-with-error-message-for branch February 23, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marktran marktran Awaiting requested review from marktran

@maxdeviant maxdeviant Awaiting requested review from maxdeviant

1 more reviewer

@jthodge jthodge jthodge approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rohanjadvani @jthodge