Skip to content

Remove create_connection and promote_draft_connection methods #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: Fix ServerException for successful DELETE operations
merged 1 commit into from
May 12, 2021
Merged

Remove create_connection and promote_draft_connection methods #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions tests/test_sso.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,31 +214,6 @@ def test_get_profile_and_token_returns_expected_workosprofile_object(
assert profile_and_token.access_token == "01DY34ACQTM3B1CSX1YSZ8Z00D"
assert profile_and_token.profile.to_dict() == mock_profile

def test_create_connection(
self, setup_with_client_id, mock_request_method, mock_connection
):
response_dict = {
"object": "connection",
"id": mock_connection["id"],
"name": mock_connection["name"],
"status": mock_connection["status"],
"connection_type": mock_connection["connection_type"],
"oauth_uid": mock_connection["oauth_uid"],
"oauth_secret": mock_connection["oauth_secret"],
"oauth_redirect_uri": mock_connection["oauth_redirect_uri"],
"saml_entity_id": mock_connection["saml_entity_id"],
"saml_idp_url": mock_connection["saml_idp_url"],
"saml_relying_party_trust_cert": mock_connection[
"saml_relying_party_trust_cert"
],
"saml_x509_certs": mock_connection["saml_x509_certs"],
"domains": mock_connection["domains"],
}
mock_request_method("post", mock_connection, 201)

connection = self.sso.create_connection("draft_conn_id")
assert connection == response_dict

def test_get_connection(
self, setup_with_client_id, mock_connection, mock_request_method
):
Expand Down
44 changes: 0 additions & 44 deletions workos/sso.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@
from workos.utils.validation import SSO_MODULE, validate_settings

AUTHORIZATION_PATH = "sso/authorize"
CREATE_CONNECTION_PATH = "connections"
PROMOTE_DRAFT_CONNECTION_PATH = "draft_connections/%s/activate"
TOKEN_PATH = "sso/token"

OAUTH_GRANT_TYPE = "authorization_code"
Expand Down Expand Up @@ -113,48 +111,6 @@ def get_profile_and_token(self, code):

return WorkOSProfileAndToken.construct_from_response(response)

def promote_draft_connection(self, token):
"""Promote a Draft Connection

Promotes a Draft Connection created through the WorkOS.js embed. A Draft Connection that has
been promoted will enable Enterprise users of the domain to begin signing in via SSO.

Args:
token (str): The token supplied via the response when a draft connection is created via
the WorkOS.js embed

Returns:
bool: True if a Draft Connection has been successfully promoted
"""
warn(
"'promote_draft_connection' is deprecated. Use 'create_connection' instead.",
DeprecationWarning,
)
self.request_helper.request(
PROMOTE_DRAFT_CONNECTION_PATH % token,
method=REQUEST_METHOD_POST,
token=workos.api_key,
)

return True

def create_connection(self, source):
"""Activates a Draft Connection created through the WorkOS.js widget.

Args:
source (str): Draft Connection identifier.

Returns:
dict: Created Connection response from WorkOS.
"""
params = {"source": source}
return self.request_helper.request(
CREATE_CONNECTION_PATH,
method=REQUEST_METHOD_POST,
params=params,
token=workos.api_key,
)

def get_connection(self, connection):
"""Gets details for a single Connection

Expand Down