feat(wpm): bump file support object#25
Merged
Merged
Conversation
smile1016
force-pushed
the
zxl/fix-bumpfile
branch
from
2daf4b3 to
22747dd
Compare
why520crazy
requested changes
May 14, 2026
| } | ||
|
|
||
| private normalizeBumpFiles(bumpFiles: any, basePath: string): string[] { | ||
| private normalizeBumpFiles(bumpFiles: any, basePath: string): BumpFile[] { |
Member
There was a problem hiding this comment.
这些 normalizeBumpFiles 在 ReleaseHandler 不是已经处理过了吗？在 bump lifecycle 直接使用就好了，为什么还要再次处理一下？
Member
There was a problem hiding this comment.
如果需要把这些逻辑移动到 lifecycle，请把 ReleaseHandler 中的逻辑去除
| const tagVersion = await latestSemverTag({ tagPrefix: context.options.tagPrefix }); | ||
| const version = context.versions.current; | ||
| this.logger.info(`current version is ${chalk.green(version)} and latest tag is ${chalk.green(tagVersion)}`); | ||
| context.options.releaseAs =context.versions.next |
why520crazy
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.