Skip to content

Mention .htaccess configuration in success message #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 16, 2017
Merged

Mention .htaccess configuration in success message #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c8948c
Mention `.htaccess` configuration in success message
danielbachhuber Aug 16, 2017
7d21b8f
Update tests with new strings to check
danielbachhuber Aug 16, 2017
fb424ba
Update one last string change
danielbachhuber Aug 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion features/core-install.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ Feature: Install WordPress core
"""
And STDOUT should contain:
"""
Success: Network installed. Don't forget to set up rewrite rules.
Success: Network installed. Don't forget to set up rewrite rules (and a .htaccess file, if using Apache).
"""

Scenario: Install WordPress multisite without adding multisite constants to wp-config file
Expand Down
6 changes: 3 additions & 3 deletions features/core.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ Feature: Manage WordPress installation
"""
Set up multisite database tables.
Added multisite constants to 'wp-config.php'.
Success: Network installed. Don't forget to set up rewrite rules.
Success: Network installed. Don't forget to set up rewrite rules (and a .htaccess file, if using Apache).
"""
And STDERR should be empty

Expand Down Expand Up @@ -190,7 +190,7 @@ Feature: Manage WordPress installation
Created single site database tables.
Set up multisite database tables.
Added multisite constants to 'wp-config.php'.
Success: Network installed. Don't forget to set up rewrite rules.
Success: Network installed. Don't forget to set up rewrite rules (and a .htaccess file, if using Apache).
"""
And STDERR should be empty

Expand Down Expand Up @@ -366,7 +366,7 @@ Feature: Manage WordPress installation
Then STDOUT should be:
"""
Set up multisite database tables.
Success: Network installed. Don't forget to set up rewrite rules.
Success: Network installed. Don't forget to set up rewrite rules (and a .htaccess file, if using Apache).
"""
And STDERR should contain:
"""
Expand Down
4 changes: 2 additions & 2 deletions src/Core_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,7 @@ public function multisite_convert( $args, $assoc_args ) {
}

if ( $this->_multisite_convert( $assoc_args ) ) {
WP_CLI::success( "Network installed. Don't forget to set up rewrite rules." );
WP_CLI::success( "Network installed. Don't forget to set up rewrite rules (and a .htaccess file, if using Apache)." );
}
}

Expand Down Expand Up @@ -509,7 +509,7 @@ public function multisite_install( $args, $assoc_args ) {
);
}

WP_CLI::success( "Network installed. Don't forget to set up rewrite rules." );
WP_CLI::success( "Network installed. Don't forget to set up rewrite rules (and a .htaccess file, if using Apache)." );
}

private static function _set_multisite_defaults( $assoc_args ) {
Expand Down