feat: add --all flag to comment delete command #546
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
| $comments = $query->query( | ||
| array( | ||
| 'fields' => 'ids', | ||
| 'number' => 0, // Get all comments |
There was a problem hiding this comment.
This sounds like it could be very slow on a large site
There was a problem hiding this comment.
Agreed, I didn't like the looping either, but I wanted it to still trigger the delete_comment and deleted_comment hooks.
Do you have any suggestions?
There was a problem hiding this comment.
Which makes sense I suppose, there is usually a lot attached to these filters. And wp_delete_comment itself does a lot as well, such as moving up children, deleting comment meta, and updating comment count. Plus, only this way can we adhere to the --force flag as well.
So yeah... there might be no way around it. Maybe it would be worth adding a warning to the docblock to indicate this might be slow if there are lots of comments.
We should probably use wp_defer_comment_counting() to defer updating comment counts, otherwise it will be done after every single deletion.
Something like:
$defer_count = wp_defer_comment_counting();
wp_defer_comment_counting( true );
// delete all comments
wp_defer_comment_counting( $defer_count )There was a problem hiding this comment.
@swissspidy Ok. I've added in the support for wp_defer_comment_counting. This got a little more complex, since the call to the parent::_delete() function exited WP-CLI after a single delete.
There was a problem hiding this comment.
@shawnhooper That's amazing, thanks a lot for diving straight in!
I see you're battling with the Behat tests. Tip: If you are expecting an error output in a test, you need to use When I try ...
There was a problem hiding this comment.
@swissspidy Yep, that did it! Thanks, was really banging my head against my desk. Thinking it was STDOUT vs STDERR issues, etc.
2 participants
Resolves #538
Contributed as part of WordCamp Canada 2025 Contributor Day. #WCEH