Add Client Implementation #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Depend on the relevant PSR packages. * `psr/http-client` (PSR-18) provides the client and supplementary interfaces. * `psr/http-factory` (PSR-17) allows de-coupling from PSR-7 implementations. * `psr/http-factory-implementation` indicates that a real PSR-17 implementation is necessary for the code to work. * Dev dep `nyholm/psr7` fulfills the above requirement for test purposes. - Deps for mocking. * The WP core itself. Besides symbols, it indicates that we depend on the latest version of WordPress for testing. This can be changed dynamically on CI later to test on a range, via CLI. * `brain/monkey` is a reliable tool for mocking functions, and is build with WordPress in mind, while being free of many of the architectural and other limitations of its competitors. The `Client` class itself is very simple, as it only performs the conversion of a PSR-7 `RequestInterface` to the WP HTTP API, and of its return into `ResponseInterface`. Most likely, this implementation isn't 100% compliant with the official spec yet.
It needed stubs, because it doesn't work well when it needs to scan a whole WP core codebase. Some additional type information was also necessary.
PHPUnit 10.4-dev gives the following: > PHP Fatal error: A never-returning function must not return in /home/runner/work/http-client/http-client/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php on line 91
Seems that there might be issues with it, causing it to report that a never-returning function returns. > PHP Fatal error: A never-returning function must not return in /home/runner/work/http-client/http-client/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php on line 91 https://github.com/wp-oop/http-client/actions/runs/5901854051/job/16008901130?pr=1 https://github.com/sebastianbergmann/phpunit/blob/main/src/Framework/Constraint/Constraint.php#L91
`Client` now throws `ClientException` if problem sending or reassembling request. At present, it is unclear how to determine specifically a network problem in order to throw the relevant exception.
mecha
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.