chore: Set default configuration for the logging plugin on activation #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds logic to set a default configuration when the plugin is activated, ensuring initial settings are present. Refactors ConfigurationHelper to remove unnecessary filters. Updates tests to verify default configuration is set on activation. Also ensures plugin constants are defined before activation/deactivation hooks are registered.
🦋 Changeset detectedLatest commit: 8156902 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📦 Plugin Artifacts Ready!Download from GitHub Actions run Available plugins:
See the "Artifacts" section at the bottom of the Actions run page |
… there is no existing config.
colinmurphy
deleted the
chore-logging-plugin-default-configuration-on-activation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This add the following default configuration upon activation if the configuration doesn't exist:
Important
We needed to load the constants before activation/de-activation hooks as this caused a fatal error when trying to the option_key for a undefined constant.
Note
We will update the docs (and screenshots) as part of the task assigned for this.
Related Issue
Fixes #472
Dependant PRs
Type of Change
How Has This Been Tested?
Locally with WordPress 6.8.2 and Faust
Screenshots
Checklist