Make fire event blocks update if the event name or parameters are changed. #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In editor, added getEventsFromWorkspace function. In mrc_call_python_funcction: Added addFireEventBlocks and createFireEventBlock functions. Replace classMethodDefBlockId and componentBlockId with otherBlockId. Replace mrcClassMethodDefBlockId and componentBlockId with otherBlockId. Make renameMethodCallers and mutateMethodCallers work for fire event blocks. Added function getComponentsFromRobot. Removed mrcComponents. Make fire event block use a field called 'EVENT' instead of 'FUNC'. In mrc_component, added getComponent function. In mrc_class_method_def: Remove mrcMethod. Added function getMethod. Added mrcFuncName which is set during python code generation. Pass commonStorage.Method (instead of ClassMethodDefExtraState) to mutateMethodCallers. In mrc_event: Added mrcNameFieldValidator and getEvent functions. Call mutateMethodCallers and renameMethodCallers user changes parameters or name. In mrc_mechanism_component_holder, added getEvents function. In event_category, call editor.getEventsFromWorkspace and addFireEventBlocks instead of using the mrc_event and mrc_call_python_function implementation details here.
…face into pr_more_cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, a lot of clean up. I'm sorry this PR is so big.
In common_storage, added Event type.
In editor, added getEventsFromWorkspace function.
In mrc_call_python_funcction:
Added addFireEventBlocks and createFireEventBlock functions. Replace classMethodDefBlockId and componentBlockId with otherBlockId. Replace mrcClassMethodDefBlockId and componentBlockId with otherBlockId. Make renameMethodCallers and mutateMethodCallers work for fire event blocks. Added function getComponentsFromRobot. Removed mrcComponents. Make fire event block use a field called 'EVENT' instead of 'FUNC'.
In mrc_component, added getComponent function.
In mrc_class_method_def:
Remove mrcMethod. Added function getMethod.
Added mrcFuncName which is set during python code generation. Pass commonStorage.Method (instead of ClassMethodDefExtraState) to mutateMethodCallers.
In mrc_event:
Added mrcNameFieldValidator and getEvent functions. Call mutateMethodCallers and renameMethodCallers user changes parameters or name.
In mrc_mechanism_component_holder, added getEvents function.
In event_category, call editor.getEventsFromWorkspace and addFireEventBlocks instead of using the mrc_event and mrc_call_python_function implementation details here.