Make copy/paste work between tabs #318
Conversation
Added code in onChangeAfterLoading to handle VIEWPORT_CHANGE and BLOCK_CREATE events. For VIEWPORT_CHANGE, set the paste location to the center of the blockly workspace. For BLOCK_CREATE, call mrcOnCreate on the newly created block (if the block has that method). In makeCurrent, set the paste workspace and location. In mrc_call_python_function.ts, mrc_component.ts, mrc_event.ts, mrc_event_handler.ts, mrc_mechanism.ts: Added mrcOnCreate so blocks that are created or pasted are checked. In mrc_call_python_function.ts, mrc_event_handler.ts, mrc_jump_to_step.ts, mrc_mechanism.ts: Check whether getIcon(Blockly.icons.IconType.WARNING) returns null. In mrc_call_python_function.ts: Added code to checkFunction to check blocks that call an instance method defined in the same module.
alan412
left a comment
alan412
left a comment
There was a problem hiding this comment.
In general I really like this, but I found a minor bug. If you copy something that isn't allowed to be copied (say a built-in method or the opmode block) there is no user indication and if you then paste it pastes what was copied before.
I think it should tell you that you can't copy that and also clear the clipboard.
…face into pr_issue_230_copy_paste
Is that minor bug introduced in this PR? Or, is that minor bug present in the main branch? |
|
Steps to reproduce:
I debated whether to accept this PR and just file it as a separate issue. I could go either way. |
|
I'd prefer to handle that bug in a separate PR. |
2 participants
Make copy/paste work between tabs.
Fixes #230
Fixes #317