Skip to content

Changed Editor.saveModule to only save if there are changes #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan412 merged 1 commit into from
Nov 22, 2025
Merged

Changed Editor.saveModule to only save if there are changes #328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 8 additions & 19 deletions src/editor/editor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,19 +301,6 @@ export class Editor {
}
}

public isModified(): boolean {
/*
// This code is helpful for debugging issues where the editor says
// 'Blocks have been modified!'.
if (this.getModuleContentText() !== this.moduleContentText) {
console.log('isModified will return true');
console.log('this.getModuleContentText() is ' + this.getModuleContentText());
console.log('this.moduleContentText is ' + this.moduleContentText);
}
*/
return this.getModuleContentText() !== this.moduleContentText;
}

public getBlocklyWorkspace(): Blockly.WorkspaceSvg {
return this.blocklyWorkspace;
}
Expand Down Expand Up @@ -470,12 +457,14 @@ export class Editor {

public async saveModule(): Promise<string> {
const moduleContentText = this.getModuleContentText();
try {
await this.storage.saveFile(this.modulePath, moduleContentText);
this.moduleContentText = moduleContentText;
await storageProject.saveProjectInfo(this.storage, this.projectName);
} catch (e) {
throw e;
if (moduleContentText !== this.moduleContentText) {
try {
await this.storage.saveFile(this.modulePath, moduleContentText);
this.moduleContentText = moduleContentText;
await storageProject.saveProjectInfo(this.storage, this.projectName);
} catch (e) {
throw e;
}
}
return moduleContentText;
}
Expand Down