Update MechanismBlock.checkMechanism to update port blocks #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If necessary, existing port blocks are reconnected to the appropriate input and new port blocks are created for empty input sockets.
alan412
requested changes
Nov 23, 2025
src/blocks/mrc_mechanism.ts
Outdated
|
|
||
| // Regenerate mrc_parameters and create new inputs if necessary. | ||
| this.mrcParameters = []; | ||
| let i = 0; |
Collaborator
There was a problem hiding this comment.
instead of handling i separately, do a forEach like this: components.forEach((component, index) => {
});
Collaborator
Author
There was a problem hiding this comment.
Here, i is not the index for components, it is the index for this.mrcParameters. I've renamed it to parametersIndex to make that more clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update MechanismBlock.checkMechanism to update port blocks.
If necessary, existing port blocks are reconnected to the appropriate input and new port blocks are created for empty input sockets.
Fixes #286