Handle method names that are python reserved words. #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thodName, and getClassMethodName methods from GeneratorContext. Removed nameFieldValue parameter from ExtendedPythonGenerator.addClassMethodDefinition method.
In the validator, check whether the proposed method name collides with existing mrc_class_method_def blocks and update caller blocks. Added maybeRenameProcedure function to mrc_call_python_function blocks.
alan412
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle method names that are python reserved words.
Fixes #73
Update mrc_call_python_function blocks in the same blockly workspace when the method name on a mrc_class_method_def block is changed.
(This does not close 71 because does not update callers if a parameter or the return type changes.