Skip to content

MNT: use pathlib.Path #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2022
Merged

MNT: use pathlib.Path #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,20 +12,20 @@
from packaging.version import Version


def pytest_collect_file(parent, path):
if path.ext == ".ipynb":
return NotebookFile.from_parent(parent, fspath=path)
def pytest_collect_file(parent, file_path):
if file_path.suffix == ".ipynb":
return NotebookFile.from_parent(parent, path=file_path)


class NotebookFile(pytest.File):
if Version(pytest.__version__) < Version("5.4.0"):

@classmethod
def from_parent(cls, parent, fspath):
return cls(parent=parent, fspath=fspath)
def from_parent(cls, parent, path):
return cls(parent=parent, path=path)

def collect(self):
for f in [self.fspath]:
for f in [self.path]:
yield NotebookItem.from_parent(self, name=os.path.basename(f))

def setup(self):
Expand All @@ -44,7 +44,7 @@ def from_parent(cls, parent, name):
return cls(parent=parent, name=name)

def runtest(self):
cur_dir = os.path.dirname(self.fspath)
cur_dir = os.path.dirname(self.path)

# See https://bugs.python.org/issue37373
if (
Expand All @@ -56,14 +56,14 @@ def runtest(self):

asyncio.set_event_loop_policy(asyncio.WindowsSelectorEventLoopPolicy())

with self.fspath.open() as f:
with self.path.open() as f:
nb = nbformat.read(f, as_version=4)
try:
self.parent.exproc.preprocess(nb, {"metadata": {"path": cur_dir}})
except CellExecutionError as e:
raise NotebookException(e)

with open(self.fspath, "wt", encoding="utf-8") as f:
with open(self.path, "wt", encoding="utf-8") as f:
nbformat.write(nb, f)

def repr_failure(self, excinfo):
Expand All @@ -73,7 +73,7 @@ def repr_failure(self, excinfo):
return super(NotebookItem, self).repr_failure((excinfo))

def reportinfo(self):
return self.fspath, 0, "TestCase: %s" % self.name
return self.path, 0, "TestCase: %s" % self.name


class NotebookException(Exception):
Expand Down