Emit the server software and version to the log on startup

[OddBloke]

As suggested (by me) in https://discuss.write.as/t/log-the-writefreely-version-on-startup/763

This follows the same format as writefreely -v, so also refactors OutputVersion() to use a new FormatVersion() function.

---

• I have signed the CLA

[thebaer]

Thanks for contributing this! Good idea, and simple enough fix.

My only feedback is that I think the log.Info() call should happen inside main() (in cmd/writefreely/main.go) instead of writefreely.Initialize(). That would keep the writefreely package flexible, and prevents logging the wrong software name / version if it's ever used for other kinds of executables. What do you think?

[OddBloke]

@thebaer Thanks for the review! I agree, and have made the change.

[ghost]

👍

[OddBloke]

Anything else I can do to push this forward?

[thebaer]

Just wanted to run it myself -- all good! Thanks for contributing this!

[OddBloke]

Thanks!

…

On Thu., Aug. 22, 2019, 13:05 Matt Baer, ***@***.***> wrote: Merged #168 <#168> into develop. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#168>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAPKEEYCXEQ27XNAN7CDILQF3BO7ANCNFSM4IKZZSTA> .