Clean up uses of temporary files in tests. #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make all `mktemp` calls specify six Xs in templates, as some systems (OpenBSD, Busybox) require that many. - Replace old `/tmp/foo.$pid`-style files with `mktemp`s, as some systems don't actually provide a `/tmp`. Also add `unwind-protect` to make temp file deletions more likely. - Give temporary test files more consistent names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make all
mktempcalls specify six Xs in templates, as some systems (OpenBSD, Busybox) require that many. Fixes OpenBSD:make testmktemp: insufficient number of Xs#188.Replace old
/tmp/foo.$pid-style files withmktemps, as some systems don't actually provide a/tmp. Also addunwind-protectto make temp file deletions more likely. Helps with Termux (Android):make testfailures with/tmp#187.Give temporary test files more consistent names.
All temporary files are created in the current directory of the running test. I think that's probably fine, though I don't consider it ideal.