Updates to configure.ac and Makefile #198
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I may have touched more than I should have with this change.
configure.ac:
--enable-strictoption for./configure; this turns on the "strict" CFLAGS-ansi -pedantic -D_POSIX_C_SOURCE=200112L -DGCDEBUG=1 -DREF_ASSERTIONS=1AC_HEADER_STDC, which only has the effect of generating a warning from autoconf.Makefile.in:
-Wdeclaration-after-statement, as it's now included in the "strict" warnings.$(ADDCFLAGS)and friends to the end of their respectiveCFLAGSand friends lines, as compiler commands largely seem to follow last-takes-precedence.make testrun./eswith-pnow, for better test consistency../testrunwithmake clean.${FOO}s to$(FOO)s for the sake of consistency.CircleCI config:
-pfor symmetry withmake test.--enable-strictinstead of manually feedingADDCFLAGSto make.