This repository was archived by the owner on Dec 24, 2023. It is now read-only.
Client-side script robustness #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wswebcreation
suggested changes
May 8, 2019
Owner
wswebcreation
left a comment
wswebcreation
left a comment
There was a problem hiding this comment.
Thanks for this PR and also nice to see that people are using the library in this way. Can you add some UT's to cover the changes?
Thanks
sneakypete81
force-pushed
the
client_script_robustness
branch
from
231e58c to
89633e9
Compare
Contributor
Author
|
Tests added - and thanks, this utility is really useful. |
Owner
|
Thanks for the update, currently at the airport, will create a new release when I'm back, will be end of the day or else tomorrow. |
wswebcreation
approved these changes
May 9, 2019
Owner
|
Tnx for the work, I've just released |
Contributor
Author
|
Nice one, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using WDIO to test a Firefox Webextension, the Geckodriver context can be set to "chrome" in order to control elements of the browser itself (toolbar, browser popups, etc.). In this context, several document attributes are not available (head, body, documentElement, etc.).
It would be useful to use webdriver-image-comparison in this context. Currently the client-side scripts fail when attempting to add/remove custom CSS and when obtaining the body/html attributes during getScreenDimensions. None of this is necessary in this context.
In this PR I've added null checks to prevent the client-side scripts from failing if these document attributes are not available.