This repository was archived by the owner on Dec 24, 2023. It is now read-only.
Update base.ts to accept functions for folder name #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi @rundmd Thanks for this PR, can you provide some examples in the docs on how this can be used? |
rundmd
force-pushed
the
set-baselinefolder-with-function-or-string
branch
2 times, most recently
from
8be67ea to
8bd7132
Compare
- allow baselineFolder to be a string or function that is passed an options object - allow screenshotPath to be a string or function that is passed an options object
rundmd
force-pushed
the
set-baselinefolder-with-function-or-string
branch
from
8bd7132 to
f4b2c92
Compare
Owner
|
This looks great, tnx! I'm going to merge it in a few days because I'm also busy with a fix so I can release them together |
Contributor
Author
|
sounds good @wswebcreation |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
options object
options object
All of our tests aren't located in the same folder. The tests are bundled inside packages along with the source code for each of our components. Our use case is saving the screenshots under the same folder as our tests.