Skip to content
This repository was archived by the owner on Dec 24, 2023. It is now read-only.

Fix/issue 31 fullpage scroll #32

Merged
merged 3 commits into from
Aug 20, 2019
Merged

Fix/issue 31 fullpage scroll #32

merged 3 commits into from
Aug 20, 2019

Conversation

wswebcreation
Copy link
Owner

@wswebcreation wswebcreation requested a review from anto-ac August 20, 2019 15:48
anto-ac
anto-ac reviewed Aug 20, 2019
View reviewed changes
@wswebcreation
Copy link
Owner Author

wswebcreation commented Aug 20, 2019 •
edited
Loading

@anto-ac

Thanks for the review. I've added documentation to explain the issue I'm solving with they try/catch, if you agree can you approve it?

@wswebcreation wswebcreation merged commit 7ec8be1 into master Aug 20, 2019
@wswebcreation wswebcreation deleted the fix/issue-13-fullpage-scroll branch August 20, 2019 18:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@anto-ac anto-ac anto-ac approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@anto-ac anto-ac

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wswebcreation @anto-ac