pass RadioField (SelectFieldBase) render_kw dict in _Option class#628
Closed
dizcza wants to merge 0 commit intopallets-eco:masterfrom
Closed
pass RadioField (SelectFieldBase) render_kw dict in _Option class#628dizcza wants to merge 0 commit intopallets-eco:masterfrom
dizcza wants to merge 0 commit intopallets-eco:masterfrom
Conversation
azmeuk
reviewed
Oct 4, 2020
Member
|
With the typo fixed, the test pass without your fix, so your fix does not actually fix your test. |
Contributor
Author
|
@azmeuk There is also an annoying style check. Do I need to follow it blindly? |
azmeuk
reviewed
Oct 4, 2020
Member
|
Yes. But you can simply run |
Member
|
This ticket seems related to #490 |
Contributor
Author
|
Done. Let me know if I need to do anything else. |
Contributor
Author
|
Hope that you squash the changes during the merge. |
Member
|
Wow. I am not sure how this issue get closed, I just rebased your branch against wtforms master. Now github does not allow me to reopen it. |
Member
|
I'm not sure how, but this has happened to me a few times too. You might be able to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RadioField ignores
render_rwdict arg. I noticed that when I was trying to passrender_rw=dict(disabled=True)as an argument in RadioField constructor.Populating
_Optionwith RadioField's.render_kwattribute solves the issue.However, there is an issue with your testing setup that does not allow me to pass
render_rwwhile creating a radio field to make a regression test.-_-