Skip to content

Add support for <optgroup> in SelectField#667

Merged
azmeuk merged 8 commits intopallets-eco:masterfrom
Giandrop:2.3.x
Sep 9, 2021
Merged

Add support for <optgroup> in SelectField#667
azmeuk merged 8 commits intopallets-eco:masterfrom
Giandrop:2.3.x

Conversation

@Giandrop
Copy link
Copy Markdown
Contributor

Add support for in SelectField as described in issue #656

@davidism
Copy link
Copy Markdown
Member

Please rebase this onto master, 2.3.x will not get another feature release.

@Giandrop Giandrop changed the base branch from 2.3.x to master October 12, 2020 03:09
@azmeuk azmeuk added the enhancement New feature, or existing feature improvement label Oct 12, 2020
@azmeuk
Copy link
Copy Markdown
Member

azmeuk commented Oct 13, 2020

Thank you for your contribution. You still have some tests failing, and some style issues.

@azmeuk azmeuk linked an issue Nov 4, 2020 that may be closed by this pull request
@azmeuk
Copy link
Copy Markdown
Member

azmeuk commented May 19, 2021

@Giandrop are you still interested in solving the issues related to this PR?

@Giandrop
Copy link
Copy Markdown
Contributor Author

Sorry, I completly forgot about this. I will be revisiting it during this weekend.

@Giandrop Giandrop marked this pull request as draft May 25, 2021 20:01
@Giandrop Giandrop marked this pull request as ready for review May 25, 2021 23:17
@Giandrop Giandrop requested a review from davidism May 28, 2021 03:22
@azmeuk azmeuk merged commit 77483ae into pallets-eco:master Sep 9, 2021
@azmeuk
Copy link
Copy Markdown
Member

azmeuk commented Sep 9, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, or existing feature improvement

Development

Successfully merging this pull request may close these issues.

SelectField <optgroup> support

3 participants