Merged
Conversation
added 3 commits
June 7, 2023 11:08
enter to apply formatting
Author
|
Seems the test is not failing because of this pr, so I'll leave it until it is fixed. |
Member
|
The failing test is related to this PR. It seems there are lines ending with spaces. diff --git a/docs/fields.rst b/docs/fields.rst
index 2c034e5..960e23f 100644
--- a/docs/fields.rst
+++ b/docs/fields.rst
@@ -313,9 +313,9 @@ refer to a single input from the form.
`coerce` keyword arg to :class:`~wtforms.fields.SelectField` says that we
use :func:`int()` to coerce form data. The default coerce is
:func:`str()`.
-
+
**Coerce function example**::
-
+
def coerce_none(value):
if value == 'None':
return None
@@ -324,7 +324,7 @@ refer to a single input from the form.
class NonePossible(From):
choices = [('1', 'Option 1'), ('2', 'Option 2'), ('None', 'No option')]
my_select_field = SelectField('Select an option', choices=choices, coerce=coerce_none)
-
+
Note when the option None is selected a 'None' str will be passed. By using a coerce
function the 'None' str will be converted to None.
style: exit 1 (22.38 seconds) /home/runner/work/wtforms/wtforms> pre-commit run --all-files --show-diff-on-failure pid=1771
style: FAIL code 1 (25.67=setup[3.29]+cmd[22.38] seconds)
evaluation failed :( (25.74 seconds)
Error: Process completed with exit code 1. |
davidism
reviewed
Jun 7, 2023
docs/fields.rst
Outdated
| return None | ||
| return value | ||
|
|
||
| class NonePossible(From): |
docs/fields.rst
Outdated
| return value | ||
|
|
||
| class NonePossible(From): | ||
| choices = [('1', 'Option 1'), ('2', 'Option 2'), ('None', 'No option')] |
Member
There was a problem hiding this comment.
This shouldn't be a class variable, inline this in the SelectField call.
Author
There was a problem hiding this comment.
I thought it would improve readability. Thanks for the feedback, I have adjusted this in the new commit.
added 2 commits
June 9, 2023 09:01
Author
|
I did a |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some form functions provide a Coerce argument. In order to make it clear what is possible, I have added a function which I use in my own product.
I did not found a solution for my problem using the docs, that is the reason to add this example.
Is this a valuable addition and is this the right place?