Skip to content

fix: display document titles during onboarding#2813

Merged
comatory merged 1 commit intomainfrom
ondrej/eng-9192-fix-title
May 4, 2026
Merged

fix: display document titles during onboarding#2813
comatory merged 1 commit intomainfrom
ondrej/eng-9192-fix-title

Conversation

@comatory
Copy link
Copy Markdown
Contributor

@comatory comatory commented May 4, 2026

Adds missing title property to onboarding pages. Without these, the browser tab would
display:

"onboarding/1" etc which is not very nice. I'm adding the PageHeader component in
the onboarding layout and re-using the step titles. We don't really have convention
for the title format but dashboard is already using Dashboard | <title> so using
similar format for onboarding seemed appropriate.

Summary by CodeRabbit

  • Refactor
    • Enhanced onboarding page layout with improved page header display and dynamic page titling.

Checklist

  • I have discussed my proposed changes in an issue and have received approval to proceed.
  • I have followed the coding standards of the project.
  • Tests or benchmarks have been added or updated.
  • Documentation has been updated on https://github.com/wundergraph/docs-website.
  • I have read the Contributors Guide.

Open Source AI Manifesto

This project follows the principles of the Open Source AI Manifesto. Please ensure your contribution aligns with its principles.

@github-actions github-actions Bot added the studio label May 4, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 16706e28-85b2-404a-b5fa-fd2121e2c4b2

📥 Commits

Reviewing files that changed from the base of the PR and between d330f59 and e7148e1.

📒 Files selected for processing (1)
  • studio/src/components/layout/onboarding-layout.tsx

Walkthrough

The OnboardingLayout component now derives a pageTitle from its optional title prop and wraps the entire layout structure in a PageHeader component. The top-level return element shifts from the layout div to the new PageHeader wrapper.

Changes

OnboardingLayout Page Title Integration

Layer / File(s) Summary
Import/Dependencies
studio/src/components/layout/onboarding-layout.tsx
PageHeader is imported from ./head.
Computed State
studio/src/components/layout/onboarding-layout.tsx
pageTitle constant is computed: "Onboarding" when no title prop is provided, otherwise `"Onboarding
Return Structure
studio/src/components/layout/onboarding-layout.tsx
The full layout markup (header, main, card, and bare content) is wrapped in <PageHeader title={pageTitle}> as the new top-level return element.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding document titles to onboarding pages, which is the primary objective of the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f996ac96-17b4-48ba-80db-7c77c75a9bdb

📥 Commits

Reviewing files that changed from the base of the PR and between 0c39bc2 and d330f59.

📒 Files selected for processing (1)
  • studio/src/components/layout/onboarding-layout.tsx

Walkthrough

OnboardingLayout component now derives a pageTitle from its optional title prop and wraps the entire layout in a PageHeader component to display this title at the header level.

Changes

Header Wrapper Integration

Layer / File(s) Summary
Import
studio/src/components/layout/onboarding-layout.tsx
PageHeader component is imported from ./head to enable header-level wrapping.
Title Derivation
studio/src/components/layout/onboarding-layout.tsx
pageTitle is derived from the optional title prop, formatted as Onboarding | <title> when provided, otherwise Onboarding.
Layout Wrapping
studio/src/components/layout/onboarding-layout.tsx
Entire layout JSX is wrapped in <PageHeader title={pageTitle}>, preserving existing logo, stepper, and content rendering logic.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and clearly describes the primary change: adding document titles to the onboarding flow to improve browser tab display.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

❌ Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 1.50%. Comparing base (abfd628) to head (e7148e1).

Files with missing lines Patch % Lines
studio/src/components/layout/onboarding-layout.tsx 0.00% 17 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (1.50%) is below the target coverage (30.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #2813      +/-   ##
========================================
- Coverage   1.50%   1.50%   -0.01%     
========================================
  Files        315     315              
  Lines      44093   44096       +3     
  Branches     451     451              
========================================
  Hits         663     663              
- Misses     43126   43129       +3     
  Partials     304     304              
Files with missing lines Coverage Δ
studio/src/components/layout/onboarding-layout.tsx 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comatory comatory marked this pull request as ready for review May 4, 2026 07:53
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@comatory comatory enabled auto-merge (squash) May 4, 2026 07:54
@comatory comatory changed the title feat: display document titles during onboarding fix: display document titles during onboarding May 4, 2026
@comatory comatory force-pushed the ondrej/eng-9192-fix-title branch from d330f59 to e7148e1 Compare May 4, 2026 18:53
@comatory comatory merged commit b6b1f9d into main May 4, 2026
13 checks passed
@comatory comatory deleted the ondrej/eng-9192-fix-title branch May 4, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants