SwiftCurrent Intermediate Representation Generator #186

morganzellers · 2022-03-04T17:48:27Z

Linked Issue:

Checklist:

Did you sign the Contributor License Agreement?
Is the linter reporting 0 errors?
Did you comply with our styleguide?
Is there adequate test coverage for your new code?
Does the CI pipeline pass?
Did you update the documentation?
Do we need to increment the minor/major version?

…lowRepresentableMetadata open - RAG MZ Co-authored-by: Richard Gist <Richard.Gist@wwt.com>

…ng AnyWorkflow - RAG MZ Co-authored-by: Richard Gist <Richard.Gist@wwt.com>

…ind starting content item in WorkflowLauncher.

…t out

…ing/launch args.

…o fail - RAG

…g for the right reasons - RAG

… needed to test launching with a workflow. Added TODO for the thenProceeds to be removed later. - RAG MZ Co-authored-by: Richard Gist <Richard.Gist@wwt.com>

Co-authored-by: Richard Gist <Richard.Gist@wwt.com>

…vate again. - RAG MZ Co-authored-by: Richard Gist <Richard.Gist@wwt.com>

Co-authored-by: Richard Gist <Richard.Gist@wwt.com>

…ng args that are not AnyWorkflow.PassedArgs and corresponding test - RAG MZ Co-authored-by: Richard Gist <Richard.Gist@wwt.com>

Launching a Workflow using an AnyWorkflow

…han 3 where we can now generate workflows from strings - RAG

…ctory

… app and added target and scheme.

…stlane - TT

… let's use that instead - TT

…astlane - TT

…ity - TT

…e - TT

Tyler-Keith-Thompson · 2022-03-24T22:38:18Z

No docs on this PR yet, we can add them now or wait, since this is not merging to main.

… still a ways to go - TT

…nt into swiftcurrent-ir-generator

…by default - TT

…online to get match working - TT

.github/SwiftCurrentLint/SwiftCurrent-IRGeneratorTests/SwiftCurrent_IRGeneratorTests.swift

…ile - TT

…, lets use it after all, just no provider needed - TT

… the pipeline - TT

…s not silently fail - TT

morganzellers and others added 30 commits November 2, 2021 11:09

[launch-with-workflow] - Added FlowRepresentableMetadataTests, made F…

ebc902f

…lowRepresentableMetadata open - RAG MZ Co-authored-by: Richard Gist <Richard.Gist@wwt.com>

[launch-with-workflow] - Added tests for new launcher initializer usi…

21a62c8

…ng AnyWorkflow - RAG MZ Co-authored-by: Richard Gist <Richard.Gist@wwt.com>

Adding support for .last computed property to AnyWorkflow

41474c3

Adds support for workflows with more than one item.

e5b0e64

Refactor of ExtendedFlowRepresentableMetadata inits and function to f…

b3c2c6b

…ind starting content item in WorkflowLauncher.

Added test for fatalError scenario in which no items in a workflow

402a9fe

WIP - Working through the tests and adding thenProceeds as I figure i…

e67d734

…t out

WIP still - added more thenProceeds but still have a lot to drive out.

3e70c53

Adds support for launching a workflow using an AnyWorkflow with start…

686cf28

…ing/launch args.

Added generic constraint test file for AnyWorkflow launched Workflows.

1d51a0a

WIP - Using generic constraints tests to drive out more thenProceeds.

4000010

[launch-with-workflow] - Adding missing init that was causing tests t…

3a2a9c4

…o fail - RAG

[launch-with-workflow] - Fixing linting error - RAG

f87bbe7

[launch-with-workflow] - Fixed some linting and got some tests passin…

d9e7845

…g for the right reasons - RAG

Merge branch 'data-driven' into launch-with-workflow

9c786ca

[launch-with-workflow] - Removed tests for thenProceed functions only…

f585656

… needed to test launching with a workflow. Added TODO for the thenProceeds to be removed later. - RAG MZ Co-authored-by: Richard Gist <Richard.Gist@wwt.com>

[launch-with-workflow] - Adding more descriptive docs - RAG MZ

ff16c99

Co-authored-by: Richard Gist <Richard.Gist@wwt.com>

[launch-with-workflow] - Added TODO to make public Workflow inits pri…

1f62b9b

…vate again. - RAG MZ Co-authored-by: Richard Gist <Richard.Gist@wwt.com>

Taking Richard's whitespace fix

9a283fd

Co-authored-by: Richard Gist <Richard.Gist@wwt.com>

[launch-with-workflow] - Adds WorkflowLauncher initializer for starti…

d5739d2

…ng args that are not AnyWorkflow.PassedArgs and corresponding test - RAG MZ Co-authored-by: Richard Gist <Richard.Gist@wwt.com>

Merge pull request #150 from wwt/launch-with-workflow

de9fe1c

Launching a Workflow using an AnyWorkflow

Merge branch 'launch-with-workflow' into data-driven

1d430cb

[skip ci] data-spike4 - This spike takes the registry a bit farther t…

7d5acb3

…han 3 where we can now generate workflows from strings - RAG

Spiked out a script to parse output from SourceKitten's structure call.

540ebb5

Added getSwiftFiles function to list all swift files in a passed dire…

c3c7533

…ctory

Added multi-calls to sourcekitten.

282d43e

WIP - Parsing json dictionary directly

73ec1e1

Cleaning up script and supporting input type

5b8e4e7

Beginning switch to swift-syntax for parsing. Added script to Example…

0b1c595

… app and added target and scheme.

Everything compiles now

50f7ddf

Tyler-Keith-Thompson and others added 6 commits March 24, 2022 16:13

[swiftcurrent-ir-generator] - Let's try to run all the tests using fa…

4622d55

…stlane - TT

[swiftcurrent-ir-generator] - Sundell wrote a thing to use the shell,…

8fd770e

… let's use that instead - TT

[swiftcurrent-ir-generator] - Minor update to testing strategy with f…

2249bd7

…astlane - TT

[swiftcurrent-ir-generator] - Minor tweak to the help on the CLI util…

cf257b7

…ity - TT

[swiftcurrent-ir-generator] - Lower deployment target for the pipelin…

34c7479

…e - TT

Merge branch 'data-driven' into swiftcurrent-ir-generator

758043a

Tyler-Keith-Thompson marked this pull request as ready for review March 24, 2022 22:37

Tyler-Keith-Thompson requested a review from a team as a code owner March 24, 2022 22:37

Tyler-Keith-Thompson assigned MattFreiburgAsynchrony Mar 24, 2022

Tyler-Keith-Thompson added 7 commits March 24, 2022 17:01

[swiftcurrent-ir-generator] - Tried adding match to help out, there's…

06e1f84

… still a ways to go - TT

[swiftcurrent-ir-generator] - Moved and updated matchfile - TT

c4f5c4b

Merge branch 'swiftcurrent-ir-generator' of github.com:wwt/SwiftCurre…

2d31664

…nt into swiftcurrent-ir-generator

[swiftcurrent-ir-generator] - Add git url to match in fastlane - TT

81ac9f5

[swiftcurrent-ir-generator] - Weirdly need http and PAT for this - TT

617418e

[swiftcurrent-ir-generator] - Think secrets are not environment vars …

7555ff6

…by default - TT

[swiftcurrent-ir-generator] - Following recommendation from somebody …

e4ab5dd

…online to get match working - TT

MattFreiburgAsynchrony approved these changes Mar 25, 2022

View reviewed changes

.github/SwiftCurrentLint/SwiftCurrent-IRGeneratorTests/SwiftCurrent_IRGeneratorTests.swift Show resolved Hide resolved

Tyler-Keith-Thompson added 10 commits March 25, 2022 10:02

[swiftcurrent-ir-generator] - More attempts to get match working - TT

e779650

[swiftcurrent-ir-generator] - Whoops, had an issue with my workflow f…

52b7bc7

…ile - TT

[swiftcurrent-ir-generator] - Remove superfluous name - TT

43e6f77

[swiftcurrent-ir-generator] - Had some cruft from a template - TT

d5f6823

[swiftcurrent-ir-generator] - Perhaps setup_ci is not needed? - TT

e70ad98

[swiftcurrent-ir-generator] - Switch to ssh - TT

c31ab3b

[swiftcurrent-ir-generator] - setup_ci does some nice keychain things…

6c31292

…, lets use it after all, just no provider needed - TT

[swiftcurrent-ir-generator] - Needed to trigger CI again - TT

30eed3a

[swiftcurrent-ir-generator] - Sadly, lower ArgumentParser version for…

04a3866

… the pipeline - TT

[swiftcurrent-ir-generator] - Silent failures are bad, therefore let'…

ef4d36c

…s not silently fail - TT

MattFreiburgAsynchrony merged commit c3558c0 into data-driven Mar 25, 2022

MattFreiburgAsynchrony deleted the swiftcurrent-ir-generator branch March 25, 2022 20:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

SwiftCurrent Intermediate Representation Generator #186

SwiftCurrent Intermediate Representation Generator #186

Uh oh!

morganzellers commented Mar 4, 2022 •

edited by Tyler-Keith-Thompson

Loading

Uh oh!

Tyler-Keith-Thompson commented Mar 24, 2022

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

SwiftCurrent Intermediate Representation Generator #186

SwiftCurrent Intermediate Representation Generator #186

Uh oh!

Conversation

morganzellers commented Mar 4, 2022 • edited by Tyler-Keith-Thompson Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Linked Issue:

Checklist:

Uh oh!

Tyler-Keith-Thompson commented Mar 24, 2022

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

morganzellers commented Mar 4, 2022 •

edited by Tyler-Keith-Thompson

Loading